fix: Add direct or/and syntax support to ProductTaxonomyInput and fix test issues #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the
contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
Also you should start your branch off our develop.
branch (right side). Don't pull request from your master!
to modify the tests here.
What does this implement/fix? Explain your changes.
This PR implements multiple enhancements and bug fixes:
1. ProductTaxonomyInput Direct OR/AND Syntax (Fixes #400)
orandandfields toProductTaxonomyInputGraphQL typeProduct_Connection_Resolverto handle both new and legacy syntaxes with properpriority
relation+filterssyntax2. OrderNotes Query Fix (Fixes #553)
orderNotesqueries were returning empty arraysCore_Schema_Filtersto make order notes visible forauthorized users
Order_Note_Typefield resolvers to properly handle Comment model propertiesown orders
3. Complete OrderNote Implementation
Order_Note_TypeGraphQL object type with full field definitionsOrder_Note_Createmutation for creating order notesOrder_Note_Deletemutation for deleting order notesusers
4. Test Improvements & Fixes
5. Infrastructure & Dependencies
.gitignorewith additional patternsbin/_lib.shNew Usage Examples:
ProductTaxonomyInput (New Syntax):
Does this close any currently open issues?
Closes #400
Closes #553
Any relevant logs, error output, GraphiQL screenshots, etc?
All tests pass successfully:
Any other comments?
This comprehensive update enhances the plugin's taxonomy filtering capabilities while fixing the long-standing orderNotes query issue (#553). The ProductTaxonomyInput changes provide the cleaner syntax requested by users while ensuring no breaking changes. The OrderNote implementation adds full CRUD operations for order notes via GraphQL mutations with proper permission handling, ensuring order notes are properly accessible through both queries and mutations. The visibility filters ensure that order owners can access their order notes while maintaining security.